Features/alignment optimization #96

MarleneBusch · 2024-11-20T09:28:32Z

Features/alignment optimization

This branch mainly introduces the AlignmentOptimizer that can be used to optimize all 28 heliostat kinematic parameters. There are two optimization methods, one uses the motor positions and the other uses raytracing. Optimizing via the motor positions is significantly faster and also more accurate.

This branch also changed other modules.

The tutorials were not updated in my last feature branch concerning the device, now the default device is also set there.
The h5 scenarios were updated to also include the power plant position coordinates.
The actuator used to have a forward method that had no use, i removed it.
The kinematic module variable names were not consistent, we used to have actuator_steps, motor_steps, actuator_pos, ... all were referring to the same thing that is named motor_positions in PAINT, thats why I chose that name for ARTIST as well.
A new pytest is introduced checking the util method that converts wgs84 to enu.
In the heliostat module, the get_surface_points_and_surface_normals method was moved from the alignement method to the init. This way it is only called once and not with each new alignment.
Inplace operations in the kinematic and raytracing were removed to make the modules differentiable.
A PAINT_to_surface converter was added to use PAINT data and create scenarios from it.
Overall I also found pieces of code that used the math library, I changed that to torch.

Fixes #91

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules

…in utils

…_position and singular

…re the data is actually used

codecov · 2024-11-20T13:34:12Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.15%. Comparing base (ac85e26) to head (fff8391).
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #96      +/-   ##
==========================================
+ Coverage   96.57%   97.15%   +0.57%     
==========================================
  Files          27       28       +1     
  Lines        1140     1299     +159     
==========================================
+ Hits         1101     1262     +161     
+ Misses         39       37       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…that stral_to_surface_converter.py is also omitted

github-actions · 2024-11-20T13:43:31Z

Name	Stmts	Miss	Cover	Missing
artist\__init__.py	5	0	100%
artist\field\__init__.py	13	0	100%
artist\field\actuator.py	16	2	88%	101, 121
artist\field\actuator_array.py	26	2	92%	91-92
artist\field\actuator_ideal.py	8	0	100%
artist\field\actuator_linear.py	38	0	100%
artist\field\facets_nurbs.py	26	0	100%
artist\field\heliostat.py	156	3	98%	117-118, 277
artist\field\heliostat_field.py	20	0	100%
artist\field\kinematic.py	10	2	80%	68, 79
artist\field\kinematic_rigid_body.py	74	0	100%
artist\field\receiver.py	41	2	95%	142, 146
artist\field\receiver_field.py	19	0	100%
artist\field\surface.py	19	0	100%
artist\raytracing\__init__.py	3	0	100%
artist\raytracing\heliostat_tracing.py	107	1	99%	4
artist\raytracing\rays.py	6	0	100%
artist\raytracing\raytracing_utils.py	9	0	100%
artist\scenario.py	117	2	98%	213, 678
artist\scene\__init__.py	4	0	100%
artist\scene\light_source.py	13	2	85%	63, 94
artist\scene\light_source_array.py	29	2	93%	88-89
artist\scene\sun.py	39	1	97%	242
artist\util\__init__.py	24	8	67%	56-57, 62-67
artist\util\alignment_optimizer.py	65	0	100%
artist\util\config_dictionary.py	167	0	100%
artist\util\nurbs.py	136	10	93%	166-167, 279, 283, 285-286, 360-361, 364-365
artist\util\utils.py	109	0	100%
TOTAL	1299	37	97%

…not bitmaps

for more information, see https://pre-commit.ci

MarleneBusch added 30 commits November 11, 2024 14:41

fix canting vectors and remove 3d to 4d conversion because it is now …

3eb2e12

…in utils

add 3d to 4d conversion methods and lat long function

ee07044

add wgs84 constants

e54b27f

fix dimensions

b1785b3

add orientation from motor positions function and rename others

b0991eb

add orientation from motor positions function and rename others

0bf08f9

add some paint data files

1b1dce1

remove measurement data from git

73cdd48

add power plant coordiantes

1011cb8

add alignment optimizer

3a16490

add power plant coordiantes

597fd94

add paint to surface converter

b931a61

add power plant coordiantes

06ce3fe

new scenario + generatorfor paint data

7564f35

adaption to changes in kinematic

3676362

test for the calibration

6fe4f39

fix indexing

5572d94

new function for lat lon to m but not working yet

e687237

add power plant config and generate new h5 files

948c60e

formatting

73d54bd

formatting

83fbd47

formatting - needs to be updated

f68b603

add power plant coordinates

999275e

formatting

1aa00ba

formatting

e3a621d

update bitmaps

55cd70b

formatting

7ed28c7

remove forward() method from actuators and rename everything to motor…

56685cb

…_position and singular

change order of computation

01b509d

remove s require grad statement

ccf9392

MarleneBusch added 13 commits November 19, 2024 17:00

refactor method

1733ad8

add expected values for alignment optimizer

a8d46f6

cleanup test

efd72e0

fix values

b2d1e38

add default device

535a143

change cuda:3 to cuda

43415e6

remove bitmap.png

46e05f9

fix bug in torch.load()

4ca2588

fix all pre-commit hook issues

e1dafea

remove unused deflec files

a18a6f5

check all paths and fix them

cc7f46a

new structure to save data in the tests and tutorials directories whe…

a719fa2

…re the data is actually used

remove old files

ba51634

remove paint_to_surface_converter.py from codecovergae because I saw …

da09bf2

…that stral_to_surface_converter.py is also omitted

MarleneBusch added 2 commits November 20, 2024 17:08

change alignment optimizer test to only compare optimized parameters …

b613012

…not bitmaps

apply pre-commit hooks

47e6936

MarleneBusch requested a review from mcw92 November 25, 2024 07:14

MarleneBusch and others added 11 commits November 26, 2024 17:28

refactor

a11c401

add getter functions for testing and tutorials

65976a6

start refactoring, but not done yet

7ea3704

add tutorials

9b5ea64

fix logger

3908869

[pre-commit.ci] auto fixes from pre-commit.com hooks

18e1437

for more information, see https://pre-commit.ci

remove cuda:3 statement

d5a492a

new expected optimized parameters

173320a

refactor

0034b3f

apply pre-commit hooks

7164025

fix

fff8391

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Features/alignment optimization #96

Features/alignment optimization #96

MarleneBusch commented Nov 20, 2024

codecov bot commented Nov 20, 2024 •

edited

Loading

github-actions bot commented Nov 20, 2024 •

edited

Loading

Features/alignment optimization #96

Are you sure you want to change the base?

Features/alignment optimization #96

Conversation

MarleneBusch commented Nov 20, 2024

Features/alignment optimization

Type of change

Checklist:

codecov bot commented Nov 20, 2024 • edited Loading

Codecov Report

github-actions bot commented Nov 20, 2024 • edited Loading

codecov bot commented Nov 20, 2024 •

edited

Loading

github-actions bot commented Nov 20, 2024 •

edited

Loading